feat: support optional array, string access and deep nil coalescing #583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonmedv
requested changes
Feb 27, 2024
| "g", | ||
| }, | ||
| { | ||
| `'string'?.[7]`, |
There was a problem hiding this comment.
This is not exactly correct behavior I'm looking for.
In case array?.[7] operator ?. checks what array itself defined and not nil.
So the code
array?.[7]
will panic in there is no 7 element index.
What we can do is to alter [7] behavior with operator ?. after it.
array[7]?.field
In this case we can alter OpFetch and do not panic if 7 index does not exist.
This mean we, unfortunately, does not have a syntax to alter [7] behavior if it is the last postfix op.
But we can alter the whole "chain" in presence of ?? operator!
array[7].field ?? 'default'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is raised to add support for optional string and array access. #540 #547 #573